Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0.0] Password Length is not validated on form submission (via PHP) #1574

Closed
thomasplevy opened this issue Mar 22, 2021 · 2 comments
Closed

[5.0.0] Password Length is not validated on form submission (via PHP) #1574

thomasplevy opened this issue Mar 22, 2021 · 2 comments
Assignees
@thomasplevy
Projects
LifterLMS v5.0.0

Comments

@thomasplevy
Copy link
Contributor

Reproduction Steps

  • This is only easy to see by faking submitted form data (thanks to html5 validation), however, we should be validating the password length via PHP anyway

Expected Behavior

  • A password that is too short for the selected min length should return an error

Actual Behavior

  • The password is accepted
@thomasplevy thomasplevy added this to To do in LifterLMS v5.0.0 via automation Mar 22, 2021
@thomasplevy thomasplevy moved this from To do to In progress in LifterLMS v5.0.0 Apr 27, 2021
@thomasplevy thomasplevy self-assigned this Apr 27, 2021
thomasplevy added a commit that referenced this issue Apr 27, 2021
@thomasplevy
Add field minlength validation, closes #1574
b1c301d
@thomasplevy thomasplevy moved this from In progress to Done in LifterLMS v5.0.0 Apr 27, 2021
@willmiddleton-lifterlms
Copy link
Member

willmiddleton-lifterlms commented Apr 30, 2021 •
edited by thomasplevy

I'm not sure if this is a related issue or a new issue, on this site, my password always is 'very weak':

https://will-video.myliftersite.com/purchase/?plan=474

Screen Shot 2021-04-30 at 11 13 44 AM

@thomasplevy
Copy link
Contributor Author

@willmiddleton-lifterlms this was fixed in
4f568a7
Not released yet though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomasplevy thomasplevy

Labels
None yet
Projects
No open projects
LifterLMS v5.0.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomasplevy @willmiddleton-lifterlms