Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Add-ons & More Banners/Author Images in Core LifterLMS #2511

Closed
kimcoleman opened this issue Aug 16, 2023 · 0 comments · Fixed by #2522
Closed

Bundle Add-ons & More Banners/Author Images in Core LifterLMS #2511

kimcoleman opened this issue Aug 16, 2023 · 0 comments · Fixed by #2522
Assignees
Labels
Severity: Normal Status: Has PR This issue has an open pull request Type: Enhancement Improvements existing features or code

Comments

@kimcoleman
Copy link
Member

Is your feature request related to a problem? Please describe.
We currently load all the images for the Add-ons & More admin screen from the LifterLMS.com website. We can bundle these images into the core plugin to reduce the draw on the LifterLMS.com site and also make images load faster for our users.

Describe the solution you'd like
We should update the single Add On view to load images relative to the core plugin.

Here are the places we load these images:

The image files can use the same "slug" as the product permalink so there is no new data to manage.

There is one primary downside to this - if we add a new item to this page, it won't be in the core plugin already.
My recommendation is to use a fallback if the image is not found, whether pulled from LifterLMS.com OR a fallback default image bundled in the core plugin for banner or "author" avatar/icon.

Describe alternatives you've considered
The alternative is that we keep doing what we are doing OR consider hosting on a separate server from our main website to lessen the load.

@actuallyakash actuallyakash self-assigned this Sep 6, 2023
@actuallyakash actuallyakash added Type: Enhancement Improvements existing features or code Status: Has PR This issue has an open pull request Severity: Normal labels Sep 13, 2023
@actuallyakash actuallyakash linked a pull request Sep 13, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Severity: Normal Status: Has PR This issue has an open pull request Type: Enhancement Improvements existing features or code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants