Bundling Add-ons & More Banners/Author Images in Core LifterLMS. #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eri-trabiccolo
suggested changes
Oct 12, 2023
|
@actuallyakash I guess you can also add the course cohorts? |
Co-authored-by: Rocco Aliberti <raliberti84@gmail.com>
Yes. Done |
eri-trabiccolo
suggested changes
Oct 13, 2023
eri-trabiccolo
requested review from
kimcoleman
and removed request for
ideadude
eri-trabiccolo
suggested changes
Oct 13, 2023
Co-authored-by: Rocco Aliberti <raliberti84@gmail.com>
Co-authored-by: Rocco Aliberti <raliberti84@gmail.com>
eri-trabiccolo
suggested changes
Oct 16, 2023
Co-authored-by: Rocco Aliberti <raliberti84@gmail.com>
eri-trabiccolo
suggested changes
Oct 16, 2023
eri-trabiccolo
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Thanks @actuallyakash this looks good to me.
@kimcoleman can we have your opinion? <3
Merged
eri-trabiccolo
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bundled all the images in Add-ons & more in Core LifterLMS.
Fixes #2511
How has this been tested?
Manually.
Types of changes
Bug fix.
Checklist: