Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4 navbar mobile misbehaving when lifterLms is active #922

Closed
Guillaume-Tnk opened this issue Sep 5, 2019 · 10 comments · Fixed by #1161 or #1221
Closed

Bootstrap 4 navbar mobile misbehaving when lifterLms is active #922

Guillaume-Tnk opened this issue Sep 5, 2019 · 10 comments · Fixed by #1161 or #1221
Assignees
Labels
Status: Has PR This issue has an open pull request

Comments

@Guillaume-Tnk
Copy link

Bug with mobile menu, not staying open when lifterlms is active with understrap theme

Reproduction Steps

Expected Behavior

menu to open/close on click on mobile as it should

Actual Behavior

Menu rapidly close on mobile when clicked

View video below
https://youtu.be/O0DpAmoZz_c

@thomasplevy
Copy link
Contributor

@Guillaume-Tnk any idea what piece of LifterLMS code is causing the issue?

@thomasplevy thomasplevy added good first issue If you're a first time contributor this is a good issue for you! hacktoberfest PRs for this issue count towards Hacktoberfest contributions! help wanted Looking for contributors to assist with this issue labels Sep 5, 2019
@thomasplevy thomasplevy added this to the Future milestone Sep 5, 2019
@Guillaume-Tnk
Copy link
Author

Unfortunately no, I just know it's coming from LifterLms because when I deactivate the lifterLms plugin, the problem disappears.
To be sure, I set a new WordPress install with just the theme and lifterLms nothing else as you can see from my video and the problem is there.

@eri-trabiccolo
Copy link
Collaborator

eri-trabiccolo commented Sep 5, 2019

@thomasplevy collapse(.min).js
lifter uses collapse.js and transition.js from bootstrap3

which conflicts with the newer scripts of boostrap4.

p.s.
From a rapid search, though, couldn't find where lifter actually uses the collapse.js code.

@Guillaume-Tnk
Copy link
Author

Any quick fix to get the menu to behave appropriately?

@thomasplevy
Copy link
Contributor

@Guillaume-Tnk

You could try de-enqueing the offending conflicts in your child theme's functions.php file.

I don't have a timeline for fixing a theme conflict I've just been made aware of but I'd be very happy to have your help working on this.

Otherwise you'll have to wait until my and @eri-trabiccolo capacity becomes freed up to start slogging away on this issue backlog, which realistically won't be until Q1 2020. Sorry :-(

@thomasplevy thomasplevy added language: php and removed good first issue If you're a first time contributor this is a good issue for you! hacktoberfest PRs for this issue count towards Hacktoberfest contributions! help wanted Looking for contributors to assist with this issue labels Oct 1, 2019
@thomasplevy thomasplevy added the Status: Has PR This issue has an open pull request label Nov 5, 2019
@thomasplevy thomasplevy self-assigned this Nov 5, 2019
@cryptexvinci
Copy link

cryptexvinci commented Feb 14, 2020

@Guillaume-Tnk

You can insert this snippet to dequeue the collapse js

add_action( 'wp_enqueue_scripts', 'remove_collapse_js', 100 );

if ( ! function_exists( 'remove_collapse_js' ) ) {
    function remove_collapse_js() {
       wp_dequeue_script( 'collapse' );
    }
}

@Guillaume-Tnk
Copy link
Author

This is working! Thank you very much.

@eri-trabiccolo
Copy link
Collaborator

@eri-trabiccolo
Copy link
Collaborator

@thomasplevy maybe candidate for v4?

@thomasplevy
Copy link
Contributor

Yea good idea, I'll have a look at this later today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Has PR This issue has an open pull request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants