Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin notifications #2478

Closed
wants to merge 9 commits into from
Closed

Conversation

seothemes
Copy link
Contributor

@seothemes seothemes commented Jul 7, 2023

Description

Adds functionality for handling admin notification banners from the server.

Testing

There are 2 constants available for testing:

// Set a custom URL to the notification JSON.
define( 'LLMS_ADMIN_NOTIFICATIONS_URL', 'https://lifter-telemetry.local/wp-content/cache/llms/notifications/notifications.json' );

// Set a custom time delay to pause notifications.
define( 'LLMS_ADMIN_NOTIFICATIONS_DELAY', 0 );

How has this been tested?

Manually

Screenshots

LifterLMS-Settings-‹-lifter-—-WordPress

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@seothemes seothemes self-assigned this Jul 17, 2023
@eri-trabiccolo
Copy link
Collaborator

hey @seothemes is this still a draft?

@eri-trabiccolo
Copy link
Collaborator

draft or ready to be reviewed? :D

@eri-trabiccolo
Copy link
Collaborator

close in favor of #2532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants