Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dashboard as default value for navigation link block #2486

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Use dashboard as default value for navigation link block #2486

merged 3 commits into from
Jul 19, 2023

Conversation

seothemes
Copy link
Contributor

Description

Adds default value (Dashboard) to LLMS Navigation Link block. Previously no default value.

Fixes #2465

How has this been tested?

Manually

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@seothemes seothemes added the Type: Enhancement Improvements existing features or code label Jul 18, 2023
@seothemes seothemes requested a review from a team July 18, 2023 05:29
@seothemes seothemes self-assigned this Jul 18, 2023
@eri-trabiccolo eri-trabiccolo removed the Type: Enhancement Improvements existing features or code label Jul 18, 2023
eri-trabiccolo
eri-trabiccolo suggested changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@eri-trabiccolo eri-trabiccolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(changelog item to change)
This works, but still in the editor the Link is gray, as if it was not set, is there anything we can do for that?
Schermata 2023-07-18 alle 09 53 21

.changelogs/nav-link-block-default.yml Outdated Show resolved Hide resolved
@eri-trabiccolo eri-trabiccolo self-requested a review July 19, 2023 15:19
eri-trabiccolo
eri-trabiccolo approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@eri-trabiccolo eri-trabiccolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks <3

@eri-trabiccolo eri-trabiccolo mentioned this pull request Jul 19, 2023
Merged
@eri-trabiccolo eri-trabiccolo merged commit 1c0c5a4 into gocodebox:dev Jul 19, 2023
22 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eri-trabiccolo eri-trabiccolo eri-trabiccolo approved these changes

Assignees

@seothemes seothemes

Labels
None yet
Projects
Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seothemes @eri-trabiccolo