Debug mode support for assets #484
Conversation
@actual-saurabh Why'd you close this? |
Oh, sorry. I was cleaning up branches on my fork and deleted this one too. Restored the branch. Should I pull from master, merge and update the pull request? |
please! I hadn't merged it in yet but it looks solid and I'd like to get it into core |
@actual-saurabh there's an issue with this... most of the JS files are only added to the assets directory as minified versions. The gulp tasks that concat & minify JS need to create a concatenated only non minified version in order for this to fully function, otherwise with script debug enabled most of the scripts will 404 |
…terlms into feature-debug-enqueue
I have added a new task to minify vendor scripts to maintain consistency. See: https://github.com/actual-saurabh/lifterlms/tree/feature-debug-enqueue/assets/js/vendor I then added this as a dependency in the original task. I also modified the original |
@thomasplevy #504, #505 describe what look like legacy remnants in assets that don't seem to be used anymore. Can I go ahead and delete them? Apart from these two, #503 describes two other scripts that have minified version in the distribution but no unminified sources to build from. |
Summary of Changes: