Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move policy apis to api repo #67

Closed

Conversation

mangoGoForward
Copy link
Contributor

@mangoGoForward
Copy link
Contributor Author

Hi @mfanjie please have a review when you have free time, and then I can import this package to each repo

@mfanjie
Copy link
Contributor

mfanjie commented Aug 22, 2022

@mangoGoForward thanks for the contribution, there is a code policy, can you make the manual code and generated code as two commits?
and would you also make the crane-scheduler change to refer the api repo?

@mangoGoForward
Copy link
Contributor Author

mangoGoForward commented Aug 22, 2022

can you make the manual code and generated code as two commits?

OK

and would you also make the crane-scheduler change to refer the api repo?

Yes, I'd like to do it~

@mangoGoForward
Copy link
Contributor Author

can you make the manual code and generated code as two commits?

Hi, @mfanjie Do you mean this pr only commit policy directory, and we need another pr to commit those generated codes?

@mfanjie
Copy link
Contributor

mfanjie commented Aug 23, 2022

@mangoGoForward two commits in single PR, please check https://github.com/gocrane/api/pull/61/commits as an example.
commit 1: all your code change
commit 2: generated code.

@mangoGoForward
Copy link
Contributor Author

@mangoGoForward two commits in single PR, please check https://github.com/gocrane/api/pull/61/commits as an example. commit 1: all your code change commit 2: generated code.

Thanks for your reminder, and already done

@mangoGoForward mangoGoForward force-pushed the refactor/move-policy branch 2 times, most recently from e501414 to 6e866af Compare August 23, 2022 07:29
Signed-off-by: mango <xu.weiKyrie@foxmail.com>
Signed-off-by: mango <xu.weiKyrie@foxmail.com>
@mfanjie
Copy link
Contributor

mfanjie commented Aug 23, 2022

I made a mistake, this api is an internal api, which should not be moved to api repo, sorry for the confusion @mangoGoForward , I am closing this pr. thanks for taking the time and submit the pr, and look forward to seeing your more contribution.

@mfanjie mfanjie closed this Aug 23, 2022
@mangoGoForward mangoGoForward deleted the refactor/move-policy branch August 23, 2022 08:44
@mangoGoForward
Copy link
Contributor Author

I made a mistake, this api is an internal api, which should not be moved to api repo, sorry for the confusion @mangoGoForward , I am closing this pr. thanks for taking the time and submit the pr, and look forward to seeing your more contribution.

Got it~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants