-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move policy apis to api repo #67
Conversation
Hi @mfanjie please have a review when you have free time, and then I can import this package to each repo |
@mangoGoForward thanks for the contribution, there is a code policy, can you make the manual code and generated code as two commits? |
OK
Yes, I'd like to do it~ |
b84f989
to
5567d08
Compare
Hi, @mfanjie Do you mean this pr only commit |
@mangoGoForward two commits in single PR, please check https://github.com/gocrane/api/pull/61/commits as an example. |
Thanks for your reminder, and already done |
e501414
to
6e866af
Compare
Signed-off-by: mango <xu.weiKyrie@foxmail.com>
Signed-off-by: mango <xu.weiKyrie@foxmail.com>
6e866af
to
33b6c89
Compare
I made a mistake, this api is an internal api, which should not be moved to api repo, sorry for the confusion @mangoGoForward , I am closing this pr. thanks for taking the time and submit the pr, and look forward to seeing your more contribution. |
Got it~ |
Signed-off-by: mango xu.weiKyrie@foxmail.com
gocrane/crane#488