Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from CGB to @wordpress/scripts #1183

Merged
merged 88 commits into from
Jan 31, 2020
Merged

Conversation

jrtashjian
Copy link
Member

@jrtashjian jrtashjian commented Dec 10, 2019

This has been a bit more difficult than anticipated specifically around our styles and code splitting with webpack 4. There is still some cleanup to do around dependencies and scripts but this is now compiling our JS and CSS using @wordpress/scripts and postcss with node-sass.

I've gone through multiple iterations of trying to simplify our styles compilation here and I think this is the best solution without too much of an overhaul. PostCSS and Sass don't really seem to work well together when it comes to compiling and from what I've seen and read it seems migrating to PostCSS could be a benefit for us.

Tasks:

@richtabor richtabor added this to the Next Release milestone Jan 27, 2020
Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and things are working on my end. Was able to get up and running very easily.

@jrtashjian jrtashjian merged commit 02f4b2c into master Jan 31, 2020
@jrtashjian jrtashjian deleted the migrate-to-wp-scripts branch January 31, 2020 03:50
@ramonjd
Copy link

ramonjd commented Feb 11, 2020

Hi @jrtashjian, I hope this isn't a dumb question: what does "CGB" stand for?

😸

@jrtashjian
Copy link
Member Author

@ramonjd Not at all! "CGB" stands for Create-Guten-Block. It is a tool that is used to scaffold out a plugin for developing blocks. It hadn't been updated in a while and wp-scripts is a similar tool (maintained by the Gutenberg project). This PR was to transition into the new tool :)

Here's the CGB project on GitHub if you're curious:
https://github.com/ahmadawais/create-guten-block

@ramonjd
Copy link

ramonjd commented Feb 11, 2020

"CGB" stands for Create-Guten-Block.

Thanks for the quick response. We were betting on something like Chips Gravy Bun, but Create-Guten-Block is also fine. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISBAT use SCRIPT_DEBUG mode with CoBlocks
5 participants