-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration from CGB to @wordpress/scripts #1183
Conversation
This reverts commit 2f20461.
5136139
to
e05908c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and things are working on my end. Was able to get up and running very easily.
Hi @jrtashjian, I hope this isn't a dumb question: what does "CGB" stand for? 😸 |
@ramonjd Not at all! "CGB" stands for Create-Guten-Block. It is a tool that is used to scaffold out a plugin for developing blocks. It hadn't been updated in a while and Here's the CGB project on GitHub if you're curious: |
Thanks for the quick response. We were betting on something like Chips Gravy Bun, but Create-Guten-Block is also fine. :) |
This has been a bit more difficult than anticipated specifically around our styles and code splitting with webpack 4. There is still some cleanup to do around dependencies and scripts but this is now compiling our JS and CSS using @wordpress/scripts and postcss with node-sass.
I've gone through multiple iterations of trying to simplify our styles compilation here and I think this is the best solution without too much of an overhaul. PostCSS and Sass don't really seem to work well together when it comes to compiling and from what I've seen and read it seems migrating to PostCSS could be a benefit for us.Tasks:
wp-scripts test:unit