Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Buttons block stability through E2E testing #1293

Merged
merged 2 commits into from
Jan 25, 2020
Merged

Improve Buttons block stability through E2E testing #1293

merged 2 commits into from
Jan 25, 2020

Conversation

EvanHerman
Copy link
Contributor

New E2E tests for the Buttons block

@EvanHerman EvanHerman added [Type] Enhancement Something new that adds functionality [Block] Buttons labels Jan 22, 2020
@EvanHerman EvanHerman self-assigned this Jan 22, 2020
@EvanHerman EvanHerman changed the title Improve Buttons block stability through E2E testing WIP: Improve Buttons block stability through E2E testing Jan 22, 2020
@cypress
Copy link

cypress bot commented Jan 22, 2020 •
edited
Loading


Test summary

3 • 0 • 0 • 0

Run details
Project CoBlocks
Status Passed
Commit f29a855
Started Jan 23, 2020 3:22 AM
Ended Jan 23, 2020 3:23 AM
Duration 00:37 💡
OS Linux Debian - 10.2
Browser Chrome 79

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@EvanHerman EvanHerman changed the title WIP: Improve Buttons block stability through E2E testing Improve Buttons block stability through E2E testing Jan 23, 2020
AnthonyLedesma
AnthonyLedesma approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great and passes tests locally. This will require a refactor when GB 7.3 is merged into core for when we deprecate coblocks/buttons in favor of core/buttons.

@jrtashjian jrtashjian merged commit 3935f7f into master Jan 25, 2020
@jrtashjian jrtashjian deleted the phase-4/buttons branch January 25, 2020 00:12
@jrtashjian jrtashjian added this to the 1.21.0 milestone Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyLedesma AnthonyLedesma AnthonyLedesma approved these changes

@jrtashjian jrtashjian Awaiting requested review from jrtashjian

@richtabor richtabor Awaiting requested review from richtabor

Assignees

@EvanHerman EvanHerman

Labels
[Type] Enhancement Something new that adds functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@EvanHerman @AnthonyLedesma @jrtashjian