Accordion inception - Issue 1645 #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed client id indicating the selected block is part of the current hierarchy
snovosel
requested review from
AnthonyLedesma,
EvanHerman,
jonathanbardo,
jrtashjian and
olafleur
as code owners
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
@snovosel This is working great! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to the accordion item component to determine if the selected block client ID matches any of the inner blocks in a recursive manner.
Fixes #1645
Description
Previously, using an accordion block within the content of a parent accordion block would prohibit the user from entering content of the nested accordion block. The additional code will check if the selected block exists within the blocks hierarchy and will remain in an "open" state if this logic returns truthy.
Screenshots
Types of changes
Bug fix
How has this been tested?
Visually
Checklist: