Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lightbox for Gallery block. #2239

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Fix Lightbox for Gallery block. #2239

merged 1 commit into from
Jan 26, 2022

Conversation

AnthonyLedesma
Copy link
Member

@AnthonyLedesma AnthonyLedesma commented Jan 25, 2022

Description

New selector in the script and logic to check the innerBlocks. This has changed since the old Gallery block had used attributes.images as opposed to innerBlocks.

Types of changes

JavaScript

How has this been tested?

Tested Manually in 5.9-RC4

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@AnthonyLedesma AnthonyLedesma added [Type] Bug Something that is not working as expected [Priority] Critical This issue/pull request needs resolving immediately, likely followed by a hot-fix labels Jan 25, 2022
@AnthonyLedesma AnthonyLedesma self-assigned this Jan 25, 2022
@cypress
Copy link

cypress bot commented Jan 25, 2022



Test summary

392 0 0 0


Run details

Project CoBlocks
Status Passed
Commit e9ea0b6
Started Jan 25, 2022 10:12 PM
Ended Jan 25, 2022 10:16 PM
Duration 03:57 💡
OS Linux Debian - 11.1
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@godaddy-wordpress-bot
Copy link
Contributor

Performance Test Results:

index master fix-lightbox-59 change %
focus 110.29 124.67 13.04%
inserterHover 35.16 37.2 5.8%
inserterOpen 103.58 111.33 7.48%
inserterSearch 100.99 89.97 -10.91%
load 21430.6 23820.8 11.15%
maxFocus 134.49 176.4 31.16%
maxInserterHover 42.49 42.57 0.19%
maxInserterOpen 396.81 445.41 12.25%
maxInserterSearch 172.81 188.67 9.18%
maxType 71.45 79.86 11.77%
minFocus 94.5 106.3 12.49%
minInserterHover 30.78 32.3 4.94%
minInserterOpen 67.39 69.54 3.19%
minInserterSearch 50.6 51.26 1.3%
minType 36.3 38.28 5.45%
type 43.64 46.44 6.42%

Copy link
Member

@olafleur-godaddy olafleur-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works also great on WP 5.9 final version, good job!

@olafleur-godaddy olafleur-godaddy merged commit c417020 into master Jan 26, 2022
@olafleur-godaddy olafleur-godaddy deleted the fix-lightbox-59 branch January 26, 2022 02:43
@AnthonyLedesma AnthonyLedesma added this to the Next Release milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] Critical This issue/pull request needs resolving immediately, likely followed by a hot-fix [Type] Bug Something that is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants