WPEX-1548 Plugin deactivation feedback modal #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download coblocks.zip: https://46381-128991767-gh.circle-artifacts.com/0/tmp/artifacts/coblocks-2266.zip |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
sbalakrishnan1-godaddy
changed the title
EvanHerman
requested review from
jrtashjian,
AnthonyLedesma,
jonathanbardo and
olafleur-godaddy
as code owners
EvanHerman
commented
Feb 21, 2022
| beforeEach( () => { | ||
| cy.intercept( | ||
| 'GET', | ||
| 'https://wpnux.godaddy.com/v3/api/feedback/coblocks-optout*', |
There was a problem hiding this comment.
@sbalakrishnan1-godaddy Try replacing this line with the following, I think that will get e2e tests working on CircleCI:
new RegExp( 'https://wpnux.godaddy.com/v3/api/feedback/coblocks-optout*' ),
EvanHerman
commented
Feb 22, 2022
| @@ -0,0 +1,128 @@ | |||
| <?php | |||
There was a problem hiding this comment.
@sbalakrishnan1-godaddy I just noticed, this class file should probably go into includes/admin/class-coblocks-plugin-deactivation.php since it's only using WordPress admin hooks.
jonathanbardo
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a form during plugin deactivation to gather feedback from users.
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
How has this been tested?
Manually tested. We will need e2e test for this.
Checklist: