Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix form button colors and fix color bleed #2461

Merged
merged 1 commit into from
Dec 20, 2022
Merged

fix form button colors and fix color bleed #2461

merged 1 commit into from
Dec 20, 2022

Conversation

AnthonyLedesma
Copy link
Member

@AnthonyLedesma AnthonyLedesma commented Dec 20, 2022

Description

Closes #2460

The original approach using styles did not work because there are other situations where the style would bleed. Change here fixes the bleed reported in #2460 and keeps the original bug resolved by ensuring the form block submit button does not apply default colors to its color component but instead inherits from the theme.

Types of changes

Remove style changes. Allow form block submit button to inherit colors from stylesheets.

How has this been tested?

Tested manually with TwentyTwentyThree and with Go theme.

Acceptance criteria

This should resolve the color bleed reported in the linked issue. It should also continue to resolve the originally attempted fix. Original bug behavior can be seen here: #2449

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@cypress
Copy link

cypress bot commented Dec 20, 2022



Test summary

401 0 2 0


Run details

Project CoBlocks
Status Passed
Commit cb31def
Started Dec 20, 2022 6:00 PM
Ended Dec 20, 2022 6:06 PM
Duration 06:11 💡
OS Linux Ubuntu -
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@godaddy-wordpress-bot
Copy link
Contributor

Performance Test Results:

index master fix-2460 change %
focus 173.2 149.68 -13.58%
inserterHover 81.91 84.63 3.32%
inserterOpen 100.83 96.62 -4.18%
inserterSearch 104.61 97.18 -7.1%
load 56766.5 57336.4 1%
maxFocus 229.49 228.77 -0.31%
maxInserterHover 101.3 96.15 -5.08%
maxInserterOpen 227.29 226.51 -0.34%
maxInserterSearch 168.23 164.83 -2.02%
maxType 191.14 133.1 -30.37%
minFocus 135.09 120.08 -11.11%
minInserterHover 77.01 73.69 -4.31%
minInserterOpen 78.51 77.54 -1.24%
minInserterSearch 80.86 73.43 -9.19%
minType 65.83 63.37 -3.74%
type 86.43 76.96 -10.96%

@AnthonyLedesma AnthonyLedesma self-assigned this Dec 20, 2022
Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to be working well on my end. Nice work! 💯

@EvanHerman EvanHerman merged commit e276049 into master Dec 20, 2022
@EvanHerman EvanHerman deleted the fix-2460 branch December 20, 2022 20:04
@AnthonyLedesma AnthonyLedesma added this to the Next Release milestone Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button background color styling lost on update to v2.25.4
3 participants