Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minor style fixes #533

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Add minor style fixes #533

merged 1 commit into from
Jun 9, 2020

Conversation

richtabor
Copy link
Contributor

Fixes missing class for .aligncenter, as well as two editor-facing style issues.

@richtabor richtabor added [Type] Bug Something that is not working as expected [Priority] Low This issue/pull request is not immediate [Status] Needs Review Tracking pull requests that need another set of eyes labels Jun 8, 2020
@richtabor richtabor requested a review from EvanHerman June 8, 2020 18:35
@richtabor richtabor self-assigned this Jun 8, 2020
@richtabor richtabor mentioned this pull request Jun 8, 2020
Merged
@cypress
Copy link

cypress bot commented Jun 8, 2020


Test summary

21 • 7 • 0 • 0

Run details
Project Go
Status Failed
Commit b778fea
Started Jun 8, 2020 6:36 PM
Ended Jun 8, 2020 6:37 PM
Duration 01:06 💡
OS Linux Debian - 10.4
Browser Multiple

View run in Cypress Dashboard ➡️

Failures

miller-traditional.spec.js ⏯ 1 Failed
1 VR Testing: miller - traditional > Loads additional pages
bento-modern.spec.js ⏯ 1 Failed
1 VR Testing: bento - modern > Loads additional pages
barista-modern.spec.js ⏯ 1 Failed
1 VR Testing: barista - modern > Loads additional pages
barista-traditional.spec.js ⏯ 1 Failed
1 VR Testing: barista - traditional > Loads additional pages
barista-welcoming.spec.js ⏯ 1 Failed
1 VR Testing: barista - welcoming > Loads additional pages
miller-welcoming.spec.js ⏯ 1 Failed
1 VR Testing: miller - welcoming > Loads additional pages
bento-welcoming.spec.js ⏯ 1 Failed
1 VR Testing: bento - welcoming > Loads additional pages

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@richtabor
Copy link
Contributor Author

These were issues I uncovered while working on the layouts.

@richtabor richtabor added this to the Next Release milestone Jun 8, 2020
EvanHerman
EvanHerman approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me

@EvanHerman EvanHerman merged commit 07711f2 into master Jun 9, 2020
@EvanHerman EvanHerman deleted the fix/style-updates branch June 9, 2020 19:30
@EvanHerman EvanHerman modified the milestones: Next Release, 1.3.0 Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHerman EvanHerman EvanHerman approved these changes

Assignees

@richtabor richtabor

Labels
[Priority] Low This issue/pull request is not immediate [Status] Needs Review Tracking pull requests that need another set of eyes [Type] Bug Something that is not working as expected
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@richtabor @EvanHerman