Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Group block's custom padding was not reflected in the editor #563

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

richtabor
Copy link
Contributor

Fixes an issue where Group block's custom padding was not reflected in the editor. To resolve this, Go's padding only gets applied if :not([class*="padding"]) exists on the block. Originally discovered by @jasonlemay.

@richtabor richtabor added [Type] Bug Something that is not working as expected [Priority] Low This issue/pull request is not immediate [Status] Needs Review Tracking pull requests that need another set of eyes labels Aug 5, 2020
@richtabor richtabor added this to the Next Release milestone Aug 5, 2020
@richtabor richtabor self-assigned this Aug 5, 2020
@cypress
Copy link

cypress bot commented Aug 5, 2020



Test summary

14 0 0 0


Run details

Project Go
Status Passed
Commit 9a2f82a
Started Aug 5, 2020 3:08 PM
Ended Aug 5, 2020 3:09 PM
Duration 01:13 💡
OS Linux Debian - 10.4
Browser Chrome 84

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@richtabor richtabor merged commit ffd9ef3 into master Aug 6, 2020
@richtabor richtabor deleted the fix/padding branch August 6, 2020 17:47
@EvanHerman EvanHerman removed the [Status] Needs Review Tracking pull requests that need another set of eyes label Aug 6, 2020
@EvanHerman EvanHerman modified the milestones: Next Release, 1.3.4 Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] Low This issue/pull request is not immediate [Type] Bug Something that is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants