Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Add custom color support w/ color scheme presets #2

Closed
3 tasks done
frankiejarrett opened this issue Jun 17, 2016 · 10 comments
Closed
3 tasks done

Add custom color support w/ color scheme presets #2

frankiejarrett opened this issue Jun 17, 2016 · 10 comments
Assignees

Comments

@tobeycodes
Copy link
Contributor

@chriswallace I have updated @fjarrett's original issue to reflect changes to make

@frankiejarrett
Copy link
Member Author

I handled most of this in the new Primer_Customizer class. @jonathanbardo is now working on splitting this up into logical parts so we don't have a 1000 line file.

@tobeycodes
Copy link
Contributor

Definitely makes more sense being in a class. Originally it was just pulled out of Twenty Sixteen and was a bit of a mess

@tobeycodes
Copy link
Contributor

I know this part was just merged from Twenty Sixteen but it makes no logical sense.

It's a callback for the custom header but changing the site-title and description

https://github.com/godaddy/wp-primer-theme/blob/issue-2-customizer/inc/customizer.php#L90-L115

@tobeycodes
Copy link
Contributor

@jonathanbardo by the way sanitize_hex_color isn't loaded outside the customizer

https://github.com/godaddy/wp-primer-theme/blob/issue-2-customizer/inc/customizer/colors.php#L321

@frankiejarrett
Copy link
Member Author

@schrapel Thanks I did this, will take a look

@tobeycodes
Copy link
Contributor

@fjarrett appreciate your work on this. Can you let me know when this stuff is in a position that we can integrate with the child themes? As of right now we are commenting out the customizer stuff since it fatals on the front end.

cc @chriswallace for ref

@frankiejarrett
Copy link
Member Author

@schrapel Oh really. I'm running 4.6-beta2 and there are no fatals. Looks like sanitize_hex_color is being moved outside of the Customizer https://core.trac.wordpress.org/ticket/27583. I will fix this for backwards compat now.

@tobeycodes
Copy link
Contributor

That's a good example of something that should have been done 2 years ago when the ticket was opened haha. Thanks

@frankiejarrett
Copy link
Member Author

Fixed in 8712948

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants