-
Notifications
You must be signed in to change notification settings - Fork 36
Add custom color support w/ color scheme presets #2
Comments
@chriswallace I have updated @fjarrett's original issue to reflect changes to make |
I handled most of this in the new |
Definitely makes more sense being in a class. Originally it was just pulled out of Twenty Sixteen and was a bit of a mess |
I know this part was just merged from Twenty Sixteen but it makes no logical sense. It's a callback for the custom header but changing the site-title and description https://github.com/godaddy/wp-primer-theme/blob/issue-2-customizer/inc/customizer.php#L90-L115 |
@jonathanbardo by the way sanitize_hex_color isn't loaded outside the customizer https://github.com/godaddy/wp-primer-theme/blob/issue-2-customizer/inc/customizer/colors.php#L321 |
@schrapel Thanks I did this, will take a look |
@fjarrett appreciate your work on this. Can you let me know when this stuff is in a position that we can integrate with the child themes? As of right now we are commenting out the customizer stuff since it fatals on the front end. cc @chriswallace for ref |
@schrapel Oh really. I'm running 4.6-beta2 and there are no fatals. Looks like |
That's a good example of something that should have been done 2 years ago when the ticket was opened haha. Thanks |
Fixed in 8712948 |
https://github.com/godaddy/wp-primer-theme/blob/feature/customizer/inc/customizer.php#L208-L264
https://github.com/godaddy/wp-primer-theme/blob/feature/customizer/inc/customizer.php#L422-L458
https://github.com/godaddy/wp-primer-theme/blob/feature/customizer/inc/customizer.php#L509-L515
https://github.com/godaddy/wp-primer-theme/blob/feature/customizer/inc/customizer.php#L538-L544
https://github.com/godaddy/wp-primer-theme/blob/feature/customizer/inc/customizer.php#L538-L544
https://github.com/godaddy/wp-primer-theme/blob/feature/customizer/inc/customizer.php#L610-L616
https://github.com/godaddy/wp-primer-theme/blob/feature/customizer/inc/customizer.php#L639-L645
The text was updated successfully, but these errors were encountered: