Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Cache CSS output #25

Closed
tobeycodes opened this issue Jul 16, 2016 · 4 comments
Closed

Cache CSS output #25

tobeycodes opened this issue Jul 16, 2016 · 4 comments

Comments

@tobeycodes
Copy link
Contributor

I think it would make logical sense to cache the entire css output, rather than calculating it on the fly for every page load.

We can flush the cache when a customizer value changes and set the cache for the first user.

What do you think?

@fjarrett
Copy link
Member

I'm not overly concerned about this since browser cache should handle this pretty well already on subsequent visits, and it would make little difference on our platform since we serve a full page cache from Varnish to logged out users.

@tobeycodes
Copy link
Contributor Author

That's fine. I was under the impression it's going on .org publicly.

@fjarrett
Copy link
Member

It is going on .org, but just saying any platform with a full-page cache and/or object cache makes this a non-issue. Would be interesting to see what the gain would be otherwise. Just store the CSS blob in a theme mod and serve that to logged out users?

@tobeycodes
Copy link
Contributor Author

Let's not worry about this for now. We can come back to it in the future if we need to

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants