ISBAT have consistent component styling in WordPress 5.3 #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLedesma
added
wp 5.3
[Type] Code Quality
|
Changed CSS for components to use less color specificity colors should be provided from GB/core. Inspiration for changes came from https://github.com/WordPress/gutenberg/blob/master/packages/components/src/button/style.scss |
AnthonyLedesma
requested review from
EvanHerman,
jrtashjian and
richtabor
as code owners
|
A few components have the new style in 5.2.4 when GB is not active. Those are the Dimensions Controls, Responsive Tabs Controls, and Grid Controls. The other components correctly inherit the color from core/GB. |
|
|
…godaddy/coblocks into consistent-component-styling-53
|
@paranoia1906 let's do one more quick run-through to make sure we've got them all. Then it's good for merge. |
|
Looks good with and without GB running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust styling for Dimensions Control components so that they resemble core style. By removing color specificity, core is able to set the color scheme.
I will review all components UI to look for changes needed for 5.3