This repository has been archived by the owner on May 29, 2024. It is now read-only.
Add open-graph page metadata for social sharing #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvogt
reviewed
Sep 12, 2018
_includes/block/head.html
Outdated
| <meta property="og:url" content="{{ site.url }}{{ page.url}}"> | ||
|
|
||
| {% if page.cover %} | ||
| <meta name="og:image" content="{{ site.url }}{{ page.cover }}"> |
There was a problem hiding this comment.
Can you update these to use the property attribute instead of name? I've been seeing these warnings in the Facebook debugger for the live site:
_includes/block/head.html
Outdated
| {% else %} | ||
| <meta name="og:image" content="{{ site.url }}/assets/images/banner.png"> | ||
| {% endif %} | ||
|
|
||
| {% if page.title %} | ||
| <meta property="og:title" content="{% if page.title %}{{ page.title }} — {% endif %}{{ site.title }}"> |
There was a problem hiding this comment.
nit: Since you are already in this file, would you mind fixing my redundant check around page.title? No problem if you don't. This line can just be:
<meta property="og:title" content="{{ page.title }} — {{ site.title }}">| {% endif %} | ||
|
|
||
| {% if page.title %} | ||
| <meta name="twitter:title" content="{{ page.title }} | @GodaddyOSS"> | ||
| {% endif %} | ||
|
|
||
| {% if page.excerpt %} | ||
| <meta property="og:description" content="{{ page.excerpt }}"> |
There was a problem hiding this comment.
nit: It would be nice to go through and give all top-level pages excerpts, but that is also fine to save for another PR.
|
@chrisvogt Thanks, pushed the changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: http://ogp.me/