Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Add auto-height Javascript for 'expand' mobile drop-downs. #78

Closed
chriswallace opened this issue Aug 29, 2016 · 3 comments
Closed

Add auto-height Javascript for 'expand' mobile drop-downs. #78

chriswallace opened this issue Aug 29, 2016 · 3 comments

Comments

@chriswallace
Copy link

chriswallace commented Aug 29, 2016

@fjarrett @jonathanbardo As I go through and fix this issue across multiple themes, I'm realizing there's no great CSS solution for matching the height of the expand button with that of the mobile menu item. When a user changes the font, it will affect the height of the menu items and change the layout. We should use Javascript to set the correct height because otherwise we will end up with mis-matched heights in a variety of cases. Flexbox would work best but is not cross-browser friendly.

Thoughts? Discuss below...

@jonathanbardo
Copy link
Member

I think flexbox is definitely not something we can use right now so I suggest we come up with a simple JS solution.

@fjarrett
Copy link
Member

@chriswallace @jonathanbardo Would the flexbox styles only be used on mobile? Because my understanding is that it's almost universally supported on mobile.

@aledesma-godaddy
Copy link

Closing issues and PRs in preparation for repository archival

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants