Merge pull request #54 from godaddy/menu-position

remove menu position from custom post type

includes/class-post-type.php

@@ -33,15 +33,6 @@ final class Post_Type {
 	 */
 	const SLUG = 'reseller_product';
 
-	/**
-	 * Post type menu position.
-	 *
-	 * @since 0.2.0
-	 *
-	 * @var int
-	 */
-	const MENU_POSITION = 52;
-
 	/**
 	 * Post type default permalink base.
 	 *
@@ -227,17 +218,16 @@ public function register() {
 		];
 
 		$args = [
-			'labels'        => $labels,
-			'description'   => esc_html__( 'This is where you can add new products to your Reseller Store.', 'reseller-store' ),
-			'menu_icon'     => 'dashicons-cart',
-			'menu_position' => self::MENU_POSITION,
-			'public'        => true,
-			'show_in_rest'  => true,
-			'rest_base'     => self::permalink_base(),
-			'query_var'     => self::permalink_base(),
-			'has_archive'   => true,
-			'supports'      => [ 'title', 'editor', 'thumbnail' ],
-			'rewrite'       => [
+			'labels'       => $labels,
+			'description'  => esc_html__( 'This is where you can add new products to your Reseller Store.', 'reseller-store' ),
+			'menu_icon'    => 'dashicons-cart',
+			'public'       => true,
+			'show_in_rest' => true,
+			'rest_base'    => self::permalink_base(),
+			'query_var'    => self::permalink_base(),
+			'has_archive'  => true,
+			'supports'     => [ 'title', 'editor', 'thumbnail' ],
+			'rewrite'      => [
 				'slug'       => self::permalink_base(),
 				'with_front' => false,
 				'feeds'      => true,

readme.md

@@ -91,6 +91,10 @@ While we recommend you use our widgets for your storefront, we do have a shortco
 
 ## Changelog ##
 
+### 1.4.0 - December 2017 ###
+
+* Fix: Remove menu position
+
 ### 1.3.0 - December 2017 ###
 
 * New: Bulk restore product post

readme.txt

@@ -87,6 +87,10 @@ While we recommend you use our widgets for your storefront, we do have a shortco
 
 == Changelog ==
 
+= 1.4.0 - December 2017 =
+
+* Fix: Remove menu position
+
 = 1.3.0 - December 2017 =
 
 * New: Bulk restore product post