Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see potential for
dbt-excel
to be used in educational contexts where the students are learning how to best use dbt, they may also be learning SQL.dbt-excel
is conducive to this situation as there is no requirement for an external database, no need to handle any credentials and the outputted data can be viewed using Excel (which most students will have prior experience of).Currently the generated
xlsx
file is saved in a directory as specified by thelocation
parameter in the models config block. When teaching students the desired structure of a dbt project (staging/intermediate/marts layers etc.) this introduces some overhead as students need to customise thelocation
parameter of each model to ensure thexlsx
files are generated in the same directory as thesql
files. This PR changes the default behaviour soxlsx
files are saved in the same directory assql
files, alocation
parameter can still be passed to overwrite this behaviour, all other file formats are unaffected.Before (without any customised
![image](https://user-images.githubusercontent.com/14027534/235606756-77c996d5-6b34-4d99-98c2-a0a7baefe64e.png)
location
parameters), files are generated in the base directory:After, files are generated in the same directory as the
![image](https://user-images.githubusercontent.com/14027534/235606277-fd4f1c91-6f44-4575-a1eb-1f72c1feb2c2.png)
sql
file: