Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test and benchmark coverage #394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pboyd04
Copy link

@pboyd04 pboyd04 commented Sep 30, 2024

This does a few things to tests:

  1. Ensure those with go routines actually complete as expected and not just rely on luck.
  2. Increase the number of benchmarks
  3. Actually compare the encoding result of the data to ensure it is accurate (the tests were just using go logic to decode to verify and if you make changes to the encoder that may still pass even though the actual output was bad. This resolves that.)
  4. Adds a Reset method to Encoder. Right now this is just used for making the Benchmarks more accurate. In the future this will be used to increase the throughput of the encoder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant