CI + codegen improvements; header update #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
quality-of-life
…rget and include! This means that JSON parsing efforts are duplicated, but we crates are more self-contained now. Each crate now has the source code it needs to process in its own directory, also confusing IDEs less.
Move conditionally-compiled symbols from unit test into own file.
Also disable recursive dev-dependency, which causes following dev-dependency cycle during cargo test.
Note that #[cfg(test)] is not carried along dependencies.
godot-core [dev]
-> godot [non-dev]
-> godot-core [non-dev]
So, we get a Heisenberg situation where both #[cfg(test)] and #[cfg(not(test))] are simultaneously true.
This also happens without any dependencies, just thanks to doctest enabling #[cfg(doctest)] but not #[cfg(test)].
The following code prints *both* errors!
#[cfg(test)]
compile_error!("test");
#[cfg(not(test))]
compile_error!("not(test)");
See comments in godot-core/lib.rs for more horror stories.
…ns with parameters
…rgs` fix (not yet in Godot)
Bromeon
force-pushed
the
qol/ci-and-codegen
branch
from
4e72546
to
2634e4d
Compare
Bromeon
force-pushed
the
qol/ci-and-codegen
branch
from
54aaf1e
to
7488b2e
Compare
|
Linux integration test currently failing because latest header change is not yet incorporated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mega-PR improves the project setup across several domains:
bindgendependencyThis was unnecessarily hard due to incomplete/unintuitive implementation of
#[cfg(test)]and#[cfg(doctest)]. These issues are not solved despite closed.godot-coreandgodot-ffinow each depend ongodot-codegen, getting rid of the "pass-through" workaroundgendirectory, instead of a sharedtarget/godot-genone