Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glam requirement from 0.19.0 to 0.20.0 #810

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 2, 2021

Updates the requirements on glam to permit the latest version.

Changelog

Sourced from glam's changelog.

[0.20.0] - 2021-11-01

Breaking changes

  • Minimum Supported Version of Rust bumped to 1.52.1 for an update to the mint crate.

Added

  • Added implementations for new IntoMint trait from the mint crate.
  • Added mint conversions for Mat3A.
  • Added as_vec3a cast methods to vector types.

[0.19.0] - 2021-10-05

Breaking changes

  • Removed truncating vector From implementations. Use .truncate() or swizzle methods instead.

Added

  • Added Not, Shl, Shr, BitAnd, BitOr and BitXor implementations for all IVec and UVec vector types.
  • Added NAN constant for all types.
  • Documented glam's architecture.

Changed

  • Sum and Product traits are now implemented in no_std builds.

[0.18.0] - 2021-08-26

Breaking changes

  • Minimum Supported Version of Rust bumped to 1.51.0 for wasm-bindgen-test and rustdoc alias support.

Added

  • Added wasm32 SIMD intrinsics support.
  • Added optional support for the rkyv serialization crate.
  • Added Rem and RemAssign implementations for all vector types.
  • Added quaternion xyz() method for returning the vector part of the quaternion.
  • Added From((Scalar, Vector3)) for 4D vector types.

Changed

  • Deprecated as_f32(), as_f64(), as_i32() and as_u32() methods in favor

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies PRs updating dependencies (dependabot automation) label Nov 2, 2021
Updates the requirements on [glam](https://github.com/bitshifter/glam-rs) to permit the latest version.
- [Release notes](https://github.com/bitshifter/glam-rs/releases)
- [Changelog](https://github.com/bitshifter/glam-rs/blob/main/CHANGELOG.md)
- [Commits](bitshifter/glam-rs@0.19.0...0.20.0)

---
updated-dependencies:
- dependency-name: glam
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/glam-0.20.0 branch from e6ac9e5 to 18e5ad1 Compare November 9, 2021 20:24
@Bromeon
Copy link
Member

Bromeon commented Nov 10, 2021

Minimum Supported Version of Rust bumped to 1.52.1 for an update to the mint crate.

Our MSRV is currently 1.48; I don't think this is worth updating. Let's see what bors means about it.
bors try

bors bot added a commit that referenced this pull request Nov 10, 2021
@bors
Copy link
Contributor

bors bot commented Nov 10, 2021

try

Build succeeded:

@Bromeon
Copy link
Member

Bromeon commented Nov 10, 2021

Interestingly, both test-linux (msrv 1.48) and itest-godot (msrv 1.48) passed. ✔️

Seems like it doesn't affect us, at least as long as we don't use mint?
On the other hand, there's also no directly added value for us when updating...

@Bromeon
Copy link
Member

Bromeon commented Nov 21, 2021

Closing, as I see no benefits of updating, and we risk breaking something.

We can reconsider this when the next glam version offers useful features, or when we add mint support.

@Bromeon Bromeon closed this Nov 21, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 21, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/glam-0.20.0 branch November 21, 2021 14:29
@Bromeon
Copy link
Member

Bromeon commented Nov 21, 2021

@dependabot ignore this minor version

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 21, 2021

OK, I won't notify you about version 0.20.x again, unless you re-open this PR or update to a 0.20.x release yourself.

@parasyte parasyte mentioned this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies PRs updating dependencies (dependabot automation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant