-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update glam requirement from 0.19.0 to 0.20.0 #810
Conversation
Updates the requirements on [glam](https://github.com/bitshifter/glam-rs) to permit the latest version. - [Release notes](https://github.com/bitshifter/glam-rs/releases) - [Changelog](https://github.com/bitshifter/glam-rs/blob/main/CHANGELOG.md) - [Commits](bitshifter/glam-rs@0.19.0...0.20.0) --- updated-dependencies: - dependency-name: glam dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
e6ac9e5
to
18e5ad1
Compare
Our MSRV is currently 1.48; I don't think this is worth updating. Let's see what bors means about it. |
tryBuild succeeded: |
Interestingly, both test-linux (msrv 1.48) and itest-godot (msrv 1.48) passed. ✔️ Seems like it doesn't affect us, at least as long as we don't use |
Closing, as I see no benefits of updating, and we risk breaking something. We can reconsider this when the next glam version offers useful features, or when we add mint support. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
@dependabot ignore this minor version |
OK, I won't notify you about version 0.20.x again, unless you re-open this PR or update to a 0.20.x release yourself. |
Updates the requirements on glam to permit the latest version.
Changelog
Sourced from glam's changelog.
... (truncated)
Commits
e98570b
Prepare 0.20.0 release.7ffd881
Update changelog.dd61905
Update mint and supportIntoMint
trait (#250)c48f69d
Fix compile error.e9b82fa
Bumped MSVR to 1.52.1 formint
crate update.8635a2e
Fixing some additional clippy lints.6e6eb98
Addas_vec3a
cast methods.b112d23
Implement mint conversions for Mat3A. (#246)b4144b5
Merge pull request #247 from benfrankel/patch-1b244631
Re-use length squared in clamp_length_minDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)