Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Update env variables and NDK preinstallation to match Godot buildsystem changes #64

Merged
merged 3 commits into from Jan 6, 2021

Conversation

m4gr3d
Copy link

@m4gr3d m4gr3d commented Jan 5, 2021

Update configuration based on the Android buildsystem change in godotengine/godot#44949.

Update configuration based on the Android buildsystem change in godotengine/godot#44949.
@akien-mga
Copy link
Member

The issue with this change is that I'll have to redownload the NDK every single time I do Android builds, which kind of defeats the purpose of using a pre-built container with all dependencies installed.

Moreover, this will fail building as I need the NDK to build the Mono runtimes in that same container build script.

Updates based on feedback.
@m4gr3d
Copy link
Author

m4gr3d commented Jan 6, 2021

The issue with this change is that I'll have to redownload the NDK every single time I do Android builds, which kind of defeats the purpose of using a pre-built container with all dependencies installed.

Moreover, this will fail building as I need the NDK to build the Mono runtimes in that same container build script.

I've updated the changes based on your feedback. We will need to ensure the ANDROID_NDK_VERSION is updated to match the project's ndkVersion. On the other hand, we can also make it an argument as for the img_version and mono_version.

Dockerfile.android Outdated Show resolved Hide resolved
@akien-mga
Copy link
Member

On the other hand, we can also make it an argument as for the img_version and mono_version.

It's fine hardcoded like done now IMO. It won't change often and it's not different from many other things hardcoded in build files like macOS and iOS SDK versions, etc.

Updates based on feedback.
@m4gr3d m4gr3d marked this pull request as ready for review January 6, 2021 15:24
@akien-mga akien-mga changed the title Update Dockerfile.android Android: Update env variables and NDK preinstallation to match Godot buildsystem changes Jan 6, 2021
@akien-mga akien-mga merged commit 3926b63 into godotengine:master Jan 6, 2021
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the patch-1 branch January 6, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants