Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve action bar on posts #8

Merged

Conversation

winston-yallow
Copy link
Collaborator

This introduces the following changes:

  • background on hover is rounded
  • mark as solved and like buttons use green font
  • background on solved and like buttons is green on hover

Default View

image

Hovered Buttons

image
image
image

With Like Count

image
image

Fixes #4
Fixes #7

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't speak CSS fluently, but the screenshots look good to me :)

@winston-yallow
Copy link
Collaborator Author

winston-yallow commented Dec 9, 2023

Forgot the state of a post being liked by you already, fixed it now. Thumb is green in this case too but filled.

image

@akien-mga
Copy link
Member

Overall, it seems to me like the accent color is red and used for everything. E.g.:
IMG_20231209_125059

We might end up playing whack-a-mole with this if we want to override it only for positively charged symbols.

Maybe we should change the accent to Godot blue?

@winston-yallow
Copy link
Collaborator Author

winston-yallow commented Dec 9, 2023

I'll see how it looks with Godot blue, would make sense to change it.

But that's unrelated to making these two buttons green, I think that's still preferred over the default accent color whatever it is. Also the like button uses the "love" color since in Discourse it originally is a heart, so even changing the default accent color would not solve #7.

@winston-yallow winston-yallow added the enhancement New feature or request label Dec 10, 2023
@winston-yallow
Copy link
Collaborator Author

Will merge during Planned Maintenance

@winston-yallow winston-yallow merged commit eab5f2a into godotengine:main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Like button is red "Solved" checkbox should be colored green
3 participants