Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Markdown or BBCode for asset descriptions #20

Open
Calinou opened this issue Aug 8, 2016 · 7 comments
Open

Support Markdown or BBCode for asset descriptions #20

Calinou opened this issue Aug 8, 2016 · 7 comments

Comments

@Calinou
Copy link
Member

Calinou commented Aug 8, 2016

Markdown or BBCode should be supported in asset descriptions. See below for a comparison of each. Perhaps the asset store could use Markdown, and convert it to BBCode when needed for Godot's purposes.

Markdown

Upsides

  • Simple to use
  • Widely used and supported

Downsides

  • Currently not supported by Godot

BBCode

Upsides

  • Supported by Godot through the RichTextLabel node

Downsides

  • Not as easy to read and write as Markdown
  • Not very popular today
@bojidar-bg
Copy link
Contributor

PHP has a PECL extension + PEAR package for BBCode - http://php.net/manual/en/book.bbcode.php

Given that it is possible to install PEAR packages through composer, I guess we might use it just fine ^^

@akien-mga
Copy link
Member

Not blocking for beta.

@akien-mga akien-mga modified the milestones: 1.0, Beta Sep 14, 2016
@Calinou
Copy link
Member Author

Calinou commented Mar 24, 2022

This is supported in the asset library rewrite, which will become the new official platform sometime in the future. I don't have an ETA for deploying it though.

@Qubus0
Copy link

Qubus0 commented Jul 15, 2023

so, without the rewrite (Calinou/godot-asset-library-laravel#467), will it be supported in this asset lib, or only in the next full rewrite mentioned in that issue?

@Calinou
Copy link
Member Author

Calinou commented Jul 15, 2023

so, without the rewrite (Calinou/godot-asset-library-laravel#467), will it be supported in this asset lib, or only in the next full rewrite mentioned in that issue?

This could be supported in the current asset library, with two conditions:

  • We find someone who's willing to integrate a Markdown parsing library in the current backend. This will require a database migration, as you need a new field to store the rendered HTML (existing field would store the source text). This HTML field would probably not be returned by the API.
  • We implement Markdown to BBCode conversion in the editor (could also be exposed to projects with a static function in RichTextLabel).

@Qubus0
Copy link

Qubus0 commented Jul 15, 2023

Does it really need a backend parser? why not keep it in the frontend only with something like https://github.com/markedjs/marked?
And, as much as I would love md to bbcode - is it really necessary? I've seen quite a few assets use markdown (mostly when the description is just the readme) and it looks completely fine

@Calinou
Copy link
Member Author

Calinou commented Jul 15, 2023

Does it really need a backend parser? why not keep it in the frontend only with something like markedjs/marked?

It can be done with a client-side library, but it may feel sluggish on low-end/mobile devices.
While we may initially expect most descriptions to be short, many people will be copy-pasting their asset's entire README if we present them with an interface that allows them to do that 🙂

And, as much as I would love md to bbcode - is it really necessary? I've seen quite a few assets use markdown (mostly when the description is just the readme) and it looks completely fine

For users, Markdown source is awkward to read unformatted when it contains named links. The rest is usually not too bad though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants