Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for placeholder_script_instance_create/update #1225

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Aug 28, 2023

This is the godot-cpp companion to PR godotengine/godot#80394

This is marked as draft because the Godot PR hasn't been merged yet.

@dsnopek dsnopek added the enhancement This is an enhancement on the current functionality label Aug 28, 2023
@dsnopek dsnopek added this to the 4.x milestone Aug 28, 2023
@dsnopek dsnopek requested a review from a team as a code owner August 28, 2023 21:11
@dsnopek dsnopek marked this pull request as draft August 28, 2023 21:11
@dsnopek dsnopek force-pushed the placeholder-script-instance branch from 421efa4 to 5ee0345 Compare August 28, 2023 21:59
@dsnopek dsnopek force-pushed the placeholder-script-instance branch from 5ee0345 to f0405f1 Compare August 28, 2023 22:02
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge once rebased.

@dsnopek dsnopek changed the title [DRAFT] Add support for placeholder_script_instance_create/update Add support for placeholder_script_instance_create/update Aug 29, 2023
@dsnopek dsnopek marked this pull request as ready for review August 29, 2023 14:10
@dsnopek
Copy link
Contributor Author

dsnopek commented Aug 29, 2023

PR godotengine/godot#80394 was merged and so the tests here are now passing

@dsnopek dsnopek merged commit 6d9416e into godotengine:master Aug 29, 2023
11 checks passed
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants