Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variant call compiler error (alternate) #1238

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Sep 9, 2023

This is PR #1017 but rebased, with the requested changes from review and with a unit test added

Fixes #1015

Co-authored-by: David Snopek <dsnopek@gmail.com>
Copy link
Collaborator

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in GDExtension meeting, this looks like a good fix, CI tests are a nice bonus :)

@dsnopek dsnopek merged commit 4314f91 into godotengine:master Sep 21, 2023
11 checks passed
@dsnopek
Copy link
Contributor Author

dsnopek commented Oct 9, 2023

Cherry-picked for 4.1 in PR #1261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation errors with Variant::call()
3 participants