Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a menu for launching GoDot from visual studio #32

Merged
merged 3 commits into from
Sep 4, 2022

Conversation

Jiiks
Copy link
Contributor

@Jiiks Jiiks commented Aug 2, 2022

No description provided.

@Intrivus
Copy link
Contributor

Intrivus commented Aug 31, 2022

I have some suggestions

image

This Launch make it Godot cuz it is Godot not GoDot :)
And you can add the Godot icon for the Godot menu and its Launch button
And make the launch button save the current scene before launch?

image

You can replace the debug button(the one that have C# text thingy) with your launch button with the Godot Engine icon
Edit: I found a workaround for have launch with Godot in tool bar but there is no icon there so adding Godot Engine icon might look great

image

Or place a Godot button next to the live share button cuz it is more efficient

And btw what is the use of the configure button

@GeorgeS2019
Copy link

@Jiiks
It is GoDot to you but Godot for the rest of us. :-)

@GeorgeS2019

This comment was marked as off-topic.

@GeorgeS2019

This comment was marked as off-topic.

@GeorgeS2019

This comment was marked as off-topic.

@GeorgeS2019

This comment was marked as off-topic.

@neikeq
Copy link
Contributor

neikeq commented Sep 1, 2022

I hid some comments because this was turning too spammy and off-topic. Those things can be talked somewhere else.

I'll give this a review tonight. The commands solutions is one I was not fond of, but since the plugin hasn't been working for a long time, we may as well accept it's the only option for now.

@GeorgeS2019
Copy link

GeorgeS2019 commented Sep 1, 2022

we may as well accept it's the only option for now.

Great, keep the iteration AND community interest and support moving forwards!

@GeorgeS2019
Copy link

@neikeq
If possible, please look into the closed PR (35), perhaps there is something useful to add to PR(32)

I believe this was closed perhaps there is a concern that there is lack of interest of PR(35)

@neikeq
Copy link
Contributor

neikeq commented Sep 1, 2022

That PR only seems to cherry-pick commits from this and another PR. I don't understand why.

@GeorgeS2019
Copy link

I think the person who submitted PR (35) has a strong enthusiasm for the UI aspect of Godot Visual Studio Extension.

I hope the community encourages him to continue the UI iteration (at least).

Copy link
Contributor

@neikeq neikeq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks: GoDot should be changed to Godot. Also, we probably want a more specific id than MyMenuGroup.
Other than that, the changes look good. I'll wait some days in case OP wants to address the nitpicks, otherwise I'll merge.

@Intrivus
Copy link
Contributor

Intrivus commented Sep 1, 2022

I have some suggestions

image

This Launch make it Godot cuz it is Godot not GoDot :) And you can add the Godot icon for the Godot menu and its Launch button And make the launch button save the current scene before launch?

image

You can replace the debug button(the one that have C# text thingy) with your launch button with the Godot Engine icon Edit: I found a workaround for have launch with Godot in tool bar but there is no icon there so adding Godot Engine icon might look great

image

Or place a Godot button next to the live share button cuz it is more efficient

And btw what is the use of the configure button

Btw make these so we can launch the game better cuz some of the feature is weird like why not make the button on tool bar and more stuff

@GeorgeS2019
Copy link

@PandoCyclone Do keep up with your enthusiasm.

I am gathering all the necessary overview and feedback. Keep it UP!

@GeorgeS2019

This comment was marked as off-topic.

@GeorgeS2019

This comment was marked as off-topic.

@neikeq
Copy link
Contributor

neikeq commented Sep 4, 2022

@GeorgeS2019 Please, don't have these discussions here. None of that seems relevant to this PR, so it feels like spam.

@neikeq neikeq merged commit dfdea8a into godotengine:master Sep 4, 2022
@neikeq
Copy link
Contributor

neikeq commented Sep 4, 2022

Thanks for the contribution!

If anyone wants to further improve this or fix typos, feels free to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants