Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing data property in Stream #1269

Closed
LinuxUserGD opened this issue Mar 29, 2018 · 3 comments
Closed

Missing data property in Stream #1269

LinuxUserGD opened this issue Mar 29, 2018 · 3 comments

Comments

@LinuxUserGD
Copy link
Contributor

LinuxUserGD commented Mar 29, 2018

Access via GDScript:

var stream = AudioStreamOGGVorbis.new()
stream.data = bytes

Affected documentation (see godotengine/godot#17748 and godotengine/godot#17848):

@LinuxUserGD
Copy link
Contributor Author

Would this be correct?

<member name="data" type="PoolByteArray" setter="set_data" getter="get_data" enum="AudioStreamSample.Data">
Audio's raw data.
</member>

@vnen
Copy link
Member

vnen commented Apr 9, 2018

This should be fixed in the code, by changing the bindings. The documentation XML is generated from that.

Edit: the property is set to be hidden, that's why it doesn't appear in docs: https://github.com/godotengine/godot/blob/93ae37f11848d481ca02a10c86812c40dec5e561/scene/resources/audio_stream_sample.cpp#L554

@LinuxUserGD
Copy link
Contributor Author

Ok thank you, so the property is used by the engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants