Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search's "No results found" message is difficult to read when using the dark theme #3498

Closed
Calinou opened this issue May 5, 2020 · 3 comments · Fixed by #3548
Closed

Search's "No results found" message is difficult to read when using the dark theme #3498

Calinou opened this issue May 5, 2020 · 3 comments · Fixed by #3548
Labels

Comments

@Calinou
Copy link
Member

Calinou commented May 5, 2020

Issue description:

When using the dark theme, the "no results found" text is difficult to read since it's black on dark gray:

image

URL to the documentation page: Visit https://docs.godotengine.org/en/latest/ and perform a search with a word that's not found in the documentation.

cc @pycbouh

@Calinou Calinou added the bug label May 5, 2020
@YuriSizov
Copy link
Contributor

Yeah, I saw that, but the issue is that these styles are applied inline instead of using classes. First and foremost it's the issue in the instant search plugin, I think. We can probably add our overrides using !important, but it's ugly...

@Calinou
Copy link
Member Author

Calinou commented May 5, 2020

We can probably add our overrides using !important, but it's ugly...

I'd argue ugly code is better than ugly appearance for the end user. 😛

Feel free to open a PR 🙂

@YuriSizov
Copy link
Contributor

@Calinou I've pinged the guys behind the extension in case they can fix it on their side before making local changes here. If they do so, I'll update our styles properly, if not, I'll do it ugly 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants