Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a dedicated "C# Signals" page #6643

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Create a dedicated "C# Signals" page #6643

merged 1 commit into from
Jan 23, 2023

Conversation

paulloz
Copy link
Member

@paulloz paulloz commented Jan 21, 2023

Part of the content was extracted from the C# Features page (we need to change that name, BTW), and part is brand new. Please do proofread, English is not my native language, but I tried to follow the writing guidelines.

mhilbrunner
mhilbrunner reviewed Jan 21, 2023
View reviewed changes
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me besides the two small comments I left.

@mhilbrunner mhilbrunner added enhancement topic:dotnet area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Jan 21, 2023
raulsntos
raulsntos reviewed Jan 21, 2023
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! We may want to also add some links to Microsoft's documentation on C# events and lambdas.

tutorials/scripting/c_sharp/c_sharp_signals.rst Outdated Show resolved Hide resolved
tutorials/scripting/c_sharp/c_sharp_signals.rst Outdated Show resolved Hide resolved
tutorials/scripting/c_sharp/c_sharp_signals.rst Show resolved Hide resolved
tutorials/scripting/c_sharp/c_sharp_signals.rst Show resolved Hide resolved
tutorials/scripting/c_sharp/c_sharp_signals.rst Outdated Show resolved Hide resolved
tutorials/scripting/c_sharp/c_sharp_signals.rst Show resolved Hide resolved
raulsntos
raulsntos approved these changes Jan 22, 2023
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhilbrunner mhilbrunner merged commit 0c18a7c into godotengine:master Jan 23, 2023
@mhilbrunner
Copy link
Member

Thank you! 🎉 Merged.

@paulloz paulloz deleted the csharp/signals branch January 23, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulloz @mhilbrunner @raulsntos