Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all instances of velocity being defined for CharacterBody2D #6862

Merged
merged 3 commits into from Mar 3, 2023
Merged

Removed all instances of velocity being defined for CharacterBody2D #6862

merged 3 commits into from Mar 3, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 2, 2023

velocity is a built-in property of CharacterBody2D. There is no need to define it, or use it in move_and_slide(). There is also no need to pass in up direction since that is a built-in property too.

Closes #6860

@mhilbrunner mhilbrunner added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.0 labels Mar 2, 2023
Copy link

@fabriceci fabriceci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhilbrunner mhilbrunner merged commit 3585c66 into godotengine:master Mar 3, 2023
@mhilbrunner
Copy link
Member

Thanks for contributing, merged! Will show up on stable once we cherrypick it. And thanks for the review!

@ghost ghost deleted the physics_introduction branch March 3, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Member "velocity" redefined (original in native class 'CharacterBody2D')
3 participants