Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix method bind instructions and style #8735

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Fix method bind instructions and style #8735

merged 2 commits into from
Jan 24, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Jan 7, 2024 •
edited

This file needs some more general cleaning up but leaving that for later

@AThousandShips AThousandShips added bug area:contributing Issues and PRs related to the Contributing/Development section of the documentation content:proofreading Issues and PRs related to proofreading the documentation cherrypick:4.1 cherrypick:4.2 labels Jan 7, 2024
@mhilbrunner @akien-mga
Update contributing/development/core_and_modules/object_class.rst
b0b01c6 
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
@mhilbrunner mhilbrunner removed the request for review from YuriSizov January 24, 2024 10:22
@mhilbrunner mhilbrunner merged commit aab5dc7 into godotengine:master Jan 24, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thanks! Merged. :)

@AThousandShips
Copy link
Member Author

Thank you!

@AThousandShips AThousandShips deleted the arg_fix branch January 24, 2024 10:25
mhilbrunner added a commit that referenced this pull request Jan 25, 2024
@AThousandShips @mhilbrunner @akien-mga
Fix method bind instructions and style (#8735)
cb3bf13 
* Fix method bind instructions and style

---------

Co-authored-by: Max Hilbrunner <mhilbrunner@users.noreply.github.com>
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov left review comments

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation bug cherrypick:4.1 content:proofreading Issues and PRs related to proofreading the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default values for arguments are in wrong order
4 participants
@AThousandShips @mhilbrunner @akien-mga @YuriSizov