Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention light appearance difference between with or without shadow in compatibility #8738

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes godotengine/godot#86695

Any suggestions are welcomed !

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Ultimately, I think we need a whole doc dedicated to the quirks of using the compatibility renderer. As this is going to seem a little hidden for users. Plus we should have comparison photos, etc.

That being said, we should merge this for now so that at least something is documented

@mhilbrunner mhilbrunner merged commit 1e604f4 into godotengine:master Jan 23, 2024
1 check passed
@mhilbrunner
Copy link
Member

Merged. Thanks for contributing! 🎉

mhilbrunner added a commit that referenced this pull request Jan 25, 2024
Mention light appearance difference between with or without shadow in compatibility
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light problem when migrating from Godot 4.1.3 to the newest version (4.2.1)
3 participants