Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sphinx-contrib libraries to pre-5.0 version #8763

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

mhilbrunner
Copy link
Member

@mhilbrunner mhilbrunner commented Jan 13, 2024

Manual squash and cherrypick of #8760 and the followup PRs #8761 and #8762.

After updates on the side of Sphinx/Sphinx requirements, we need to pin these versions of these requirements that are included by Sphinx as the newer ones depend on Sphinx 5.0+, while we are still on 4.x.

This needs to be cherrypicked to all active branches that are built on ReadTheDocs to ensure builds keep working there.

@mhilbrunner mhilbrunner merged commit 4f2ca50 into godotengine:4.2 Jan 25, 2024
1 check passed
@mhilbrunner mhilbrunner deleted the sphinx-5-contrib-fix branch January 25, 2024 08:26
@mhilbrunner
Copy link
Member Author

Cherrypicked to 3.6 in #8857.

@mhilbrunner mhilbrunner restored the sphinx-5-contrib-fix branch May 7, 2024 11:36
@mhilbrunner mhilbrunner mentioned this pull request May 7, 2024
mhilbrunner added a commit that referenced this pull request May 7, 2024
Pin sphinx-contrib libraries to pre-5.0 version

(cherry picked from commit 4f2ca50)
@mhilbrunner mhilbrunner mentioned this pull request May 8, 2024
mhilbrunner added a commit that referenced this pull request May 8, 2024
Pin sphinx-contrib libraries to pre-5.0 version

(cherry picked from commit 4f2ca50)
@mhilbrunner
Copy link
Member Author

Cherry-picked to 4.1 in #9343, and to 4.0 in #9351.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:3.5 python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant