Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a undo/redo history log #953

Closed
golddotasksquestions opened this issue May 28, 2020 · 4 comments · Fixed by godotengine/godot#65012
Closed

Add a undo/redo history log #953

golddotasksquestions opened this issue May 28, 2020 · 4 comments · Fixed by godotengine/godot#65012

Comments

@golddotasksquestions
Copy link

Describe the project you are working on: This applies to any game or project

Describe the problem or limitation you are having in your project:
I don't know which action I can undo and which action I can't undo. Jumping back and forth in the undo history is anything but transparent or user friendly.

Describe the feature / enhancement and how it helps to overcome the problem or limitation:
A panel with a history log for all undoable steps. Branching undo tree would be amazing, but a linear list would already be a great improvement.
Issue moved here from godotengine/godot#25919

Describe how your proposal will work, with code, pseudocode, mockups, and/or diagrams:
undohistory

If this enhancement will not be used often, can it be worked around with a few lines of script?:
I don't think so.

Is there a reason why this should be core and not an add-on in the asset library?:
It's a core usability feature.

@kyleguarco
Copy link

kyleguarco commented May 28, 2020

This is already sort of implemented. When you do anything with a scene in the editor, a message is printed to the console, telling you which property you edited.

Rather than calling it an undo log, let's call it an action history. This already-implemented editor feature can be edited to include the action history on a per-scene basis. Maybe this history can be saved to a dotfile (similar to .import) so it persists when you open the editor.

@golddotasksquestions
Copy link
Author

golddotasksquestions commented May 29, 2020

Hm, the logging may be implemented, but when I hit Ctrl+Z a couple times, I have no idea "where" I am in the history. Knowing where I am is the main purpose of such a panel or visualization. The added bonus of being able to just click on any undo state (or "action") as shown in the gif above would be another very desirable UX improvement.
Currently you are completely blind as to where you are in the history and often just have to guess. So I would not say this proposal is already implemented.

@bojidar-bg
Copy link

Note that it might actually be possible to get the editor's UndoRedo and display a panel which displays the actions stored in that UndoRedo, all inside a plugin.

I do agree that it might be nicer to have it out of the box, however.

@me2beats
Copy link

me2beats commented Nov 3, 2020

Imo this wouldn't be very useful without implementing this #1630
@bojidar-bg I tried to make it as a gdscript plugin but I didn't find some basic api methods
like #1745 and #1746 Without them it's not possible to make a proper undo history list plugin

@Calinou Calinou changed the title Add Undo/redo history log Add a undo/redo history log Nov 14, 2020
@akien-mga akien-mga added this to the 4.0 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Implemented
Development

Successfully merging a pull request may close this issue.

6 participants