Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow right-clicking node visibility icon to toggle solo visibility #9782

Open
yankscally opened this issue May 19, 2024 · 6 comments
Open

Comments

@yankscally
Copy link

yankscally commented May 19, 2024

Describe the project you are working on

any

Describe the problem or limitation you are having in your project

being able to quickly "solo" view a node by hiding all other nodes.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

a way to toggle a single node (and its children) as visible.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

image

simply right clicking the eye icon could hide all other nodes.

If this enhancement will not be used often, can it be worked around with a few lines of script?

it could be an editorplugin, but I think it should be built-in

Is there a reason why this should be core and not an add-on in the asset library?

its too internal for an editorplugin, I think.

@SheepCommander
Copy link

SheepCommander commented May 19, 2024

Honestly this is an interesting idea, but this can definitely be done with an EditorPlugin.

Also I think you mean that it hides every node except its children? And in that case would all of its children also be set to visible or would they keep their previous visbility?

I would say this has a lot of disputable edge cases that make it unwieldy to be added to the editor, but it would be a pretty cool plugin

@Calinou
Copy link
Member

Calinou commented May 19, 2024

I think this is an interesting idea, but what bothers me is that it would be a "destructive" operation (without relying on undo/redo). If you toggle solo mode again, it would make all nodes in the scene visible again, including nodes that were hidden previously.

It might be worth pursuing if we find a way to make this non-destructive, akin to Blender (which I think has a shortcut for this).

@Calinou Calinou changed the title toggle visibility: solo Allow right-clicking node visibility icon to toggle solo visibility May 19, 2024
@SheepCommander
Copy link

SheepCommander commented May 19, 2024

Just now opened up blender (for the first time) to check:

H hides selections, Alt+H unhides selections,

Shift+H hides everything except selection. Pressing Alt+H after Shift+H unhides everything that was hidden, including any objects that were previously hidden.

So, it seems that in Blender, this is a destructive operation

@SheepCommander
Copy link

SheepCommander commented May 20, 2024

@yankscally Incase you want it, I made a quick addon for it here. SheepCommander/gd-SoloVisibility. It's now uploaded to the Asset Library!

@lostminds
Copy link

I could see that use for the solo visibility toggle, but I think right-clicking to do it would be a bad way to access it as right-click is something the user associates with bringing up context menus. I'd suggest using left-click with a modifier key instead, maybe Alt? This would also allow the button to indicate this separate functionality with a modified icon on hover with the modifier held.

As for the destructive nature of this I agree for the case where you have a parent with many nodes in different visibility states. However, if this only applies to other nodes of the same parent (so not the entire scene tree) I think it will mostly be used in simple cases where all nodes in the parent are visible and you can then toggle them to hidden, and then back to visible by toggling again. If you unintentionally toggle a group visibility all off when you didn't want it you can always use undo, and then not use this solo visibility toggle feature for these cases.

@Calinou
Copy link
Member

Calinou commented Jun 14, 2024

I could see that use for the solo visibility toggle, but I think right-clicking to do it would be a bad way to access it as right-click is something the user associates with bringing up context menus. I'd suggest using left-click with a modifier key instead, maybe Alt? This would also allow the button to indicate this separate functionality with a modified icon on hover with the modifier held.

The layers (bitfield) property editor in the inspector uses Ctrl + Click for solo mode, so I'd probably use Ctrl + Click here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants