This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Fix some small bugs of filter methods (part 1) #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keroro520
force-pushed
the
refactor-eth-filter-methods-part-1
branch
from
b22e5d5
to
66ab37a
Compare
This was referenced Jul 8, 2022
keroro520
force-pushed
the
refactor-eth-filter-methods-part-1
branch
from
66ab37a
to
7da4619
Compare
classicalliu
approved these changes
Jul 13, 2022
RetricSu
reviewed
Jul 13, 2022
RetricSu
approved these changes
Jul 13, 2022
keroro520
force-pushed
the
refactor-eth-filter-methods-part-1
branch
from
7da4619
to
ac4e3f7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some test cases, which helped me identify some bugs: godwokenrises/godwoken-tests#143
This PR brings some small bugfixes for them.