Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

fix: Update insufficient balance error message #473

Merged
merged 1 commit into from
Aug 1, 2022
Merged

fix: Update insufficient balance error message #473

merged 1 commit into from
Aug 1, 2022

Conversation

classicalliu
Copy link
Contributor

  • Update error message if balance < requiredBalance when send transaction
  • Remove balance > 0 check in eth_call & eth_estimateGas

@classicalliu classicalliu linked an issue Jul 28, 2022 that may be closed by this pull request
[BUG] "from id not found by from Address" when the transfer account balance is insufficient #468
Closed
@Flouse Flouse changed the base branch from main to 1.5-rc July 29, 2022 11:00
@Flouse Flouse mentioned this pull request Jul 29, 2022
Closed
@RetricSu
Copy link
Contributor

RetricSu commented Aug 1, 2022 •
edited
Loading

please cherry-pick or rebase to 1.5-rc branch @classicalliu

@classicalliu
Copy link
Contributor Author

please cherry-pick or rebase to 1.5-rc branch @classicalliu

Updated

@RetricSu RetricSu merged commit b6f0093 into 1.5-rc Aug 1, 2022
@RetricSu RetricSu deleted the update-balance-0-error branch August 1, 2022 02:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Flouse Flouse Flouse approved these changes

@zeroqn zeroqn zeroqn approved these changes

@RetricSu RetricSu RetricSu approved these changes

@gpBlockchain gpBlockchain gpBlockchain approved these changes

Assignees

@classicalliu classicalliu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] "from id not found by from Address" when the transfer account balance is insufficient
5 participants
@classicalliu @RetricSu @Flouse @zeroqn @gpBlockchain