Fix issue with intepreting unbounded sequences as having a max limit of 2

[jbuncle]

Fix for issue as described in goetas-webservices/xsd2php#135 where sequences with unbounded maxOccurs are being treated as having a limit of 2 when generating validation rules.

<xs:sequence maxOccurs="unbounded">
</xs:sequence>

Was generating validation rules as:

            -
                Count:
                    max: 2
                    groups:
                        - xsd_rules

Where they should be unlimited

[Guite]

I am not sure but for me it looks like it should be something like:

        $max =
            (
                (is_int($max) && (bool) $max) ||
                0 < $node->getAttribute('maxOccurs')
            ) && ('unbounded' !== $node->getAttribute('maxOccurs'))
                ? (int) min((int) $max, $node->getAttribute('maxOccurs'))
                : null;

similarly as it is done with $min further below.

Can you please review this proposal?

[Guite]

@goetas can you also maybe take a look at this?

[goetas]

@jbuncle can you please add a test for this?

[Guite]

@jbuncle I like that you extracted the logic into a dedicated method loadMaxFromNode. Would you please invest a few more minutes in order to do the same with the min value (introduce loadMinFromNode as well)? Thank you very much!

[Guite]

do the same with the min value (introduce loadMinFromNode as well)

will do that in a separate step

thanks for your contribution