Fixed spl_object_hash collisions using internal attribute. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
referenced
this pull request
Apr 25, 2015
In certain edge case we can have spl_object_hash collisions, so lets use also some node data
| { | ||
| return "__a9" . strtr(md5($node->ownerDocument->saveXML($node)).spl_object_hash($node), "-","_"); | ||
| return "__a9" . strtr($node->getAttributeNS(Twital::NS, '__internal-id__').spl_object_hash($node), "-","_"); |
There was a problem hiding this comment.
Wasn't the whole point of this to replace spl_object_hash with some unique key? Or maybe I just don't understand how it works now.
There was a problem hiding this comment.
Oh, I get it now. First part of hash is unique for current document and second part ensures that it won't colide with normal variables.
There was a problem hiding this comment.
It is also possible to create plugins that are able to "clone" dom nodes. Cloning a node, the __internal-id__ will remain untouched, so using both spl_object_hash and __internal-id__ the node identifier "should" be more reliable.
goetas
added a commit
that referenced
this pull request
May 1, 2015
Fixed spl_object_hash collisions using internal attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
Test suite is still missing