fix(client): return error in SetProxyURL instead of panic

client/client.go

@@ -7,6 +7,7 @@ import (
 	"encoding/json"
 	"encoding/xml"
 	"errors"
+	"fmt"
 	"io"
 	urlpkg "net/url"
 	"os"
@@ -226,21 +227,19 @@ func (c *Client) SetRootCertificateFromString(pem string) *Client {
 }
 
 // SetProxyURL sets proxy url in client. It will apply via core to hostclient.
-func (c *Client) SetProxyURL(proxyURL string) *Client {
+func (c *Client) SetProxyURL(proxyURL string) error {
 	pURL, err := urlpkg.Parse(proxyURL)
 	if err != nil {
-		c.logger.Panicf("client: %v", err)
-		return c
+		return fmt.Errorf("client: %w", err)
 	}
 
 	if pURL.Scheme != "http" && pURL.Scheme != "https" {
-		c.logger.Panicf("client: %v", ErrInvalidProxyURL)
-		return c
+		return fmt.Errorf("client: %w", ErrInvalidProxyURL)
 	}
 
 	c.proxyURL = pURL.String()
 
-	return c
+	return nil
 }
 
 // RetryConfig returns retry config in client.

client/client_test.go

@@ -1549,8 +1549,11 @@ func Test_Client_SetProxyURL(t *testing.T) {
 	t.Run("success", func(t *testing.T) {
 		t.Parallel()
 		client := NewClient().SetDial(dial)
-		client.SetProxyURL("http://test.com")
-		_, err := client.Get("http://localhost:3000")
+		err := client.SetProxyURL("http://test.com")
+
+		require.NoError(t, err)
+
+		_, err = client.Get("http://localhost:3000")
 
 		require.NoError(t, err)
 	})
@@ -1559,18 +1562,18 @@ func Test_Client_SetProxyURL(t *testing.T) {
 		t.Parallel()
 		client := NewClient()
 
-		require.Panics(t, func() {
-			client.SetProxyURL(":this is not a url")
-		})
+		err := client.SetProxyURL(":this is not a url")
+
+		require.Error(t, err)
 	})
 
 	t.Run("error", func(t *testing.T) {
 		t.Parallel()
 		client := NewClient()
 
-		require.Panics(t, func() {
-			client.SetProxyURL("htgdftp://test.com")
-		})
+		err := client.SetProxyURL("htgdftp://test.com")
+
+		require.Error(t, err)
 	})
 }