Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Add earlydata middleware #2270

Merged
merged 4 commits into from
Jan 27, 2023

Conversation

leonklingele
Copy link
Member

@leonklingele leonklingele commented Dec 12, 2022

Description

Add earlydata middleware to add support for TLS 1.3's early data ("0-RTT") feature.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - https://github.com/gofiber/docs for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

@leonklingele
Copy link
Member Author

Any news here? Would be nice to have this in the next release! 馃槉

@ReneWerner87
Copy link
Member

Will check it tomorrow

Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leonklingele some little adjustments needed

@leonklingele
Copy link
Member Author

@ReneWerner87 addressed your comments. ptal 馃槉

@ReneWerner87 ReneWerner87 merged commit 7170b2a into gofiber:v3-beta Jan 27, 2023
leonklingele added a commit to leonklingele/fiber that referenced this pull request Jan 28, 2023
* middleware: add earlydata middleware

* middleware/earlydata: address comments

* Update README.md

* Update README.md

Co-authored-by: RW <rene@gofiber.io>
leonklingele added a commit to leonklingele/fiber that referenced this pull request Jan 28, 2023
leonklingele added a commit to leonklingele/fiber that referenced this pull request Jan 28, 2023
leonklingele added a commit to leonklingele/fiber that referenced this pull request Jan 29, 2023
ReneWerner87 added a commit that referenced this pull request Jan 30, 2023
* 馃殌 Feature: Add earlydata middleware (#2270)

* middleware: add earlydata middleware

* middleware/earlydata: address comments

* Update README.md

* Update README.md

Co-authored-by: RW <rene@gofiber.io>

* middleware/earlydata: backport to v2

Backport of #2270 to v2.

---------

Co-authored-by: RW <rene@gofiber.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants