Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bug: fix method validation on route naming #2686

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Conversation

efectn
Copy link
Member

@efectn efectn commented Oct 21, 2023

Description

Fixes #2685

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - /docs/ directory for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@efectn
Copy link
Member Author

efectn commented Oct 21, 2023

Hi @Antonov-guap and @trapcodeio. Can you check the PR?

app_test.go Show resolved Hide resolved
@trapcodeio
Copy link

Hi @Antonov-guap and @trapcodeio. Can you check the PR?

I would love to, but how do I use/test that particular branch?

@efectn
Copy link
Member Author

efectn commented Oct 21, 2023

Hi @Antonov-guap and @trapcodeio. Can you check the PR?

I would love to, but how do I use/test that particular branch?

go get github.com/gofiber/fiber/v2@fix-route-naming should work

@trapcodeio
Copy link

Hi @Antonov-guap and @trapcodeio. Can you check the PR?

I would love to, but how do I use/test that particular branch?

go get github.com/gofiber/fiber/v2@fix-route-naming should work

Thanks, I have learned something new today 😁.

I just tried it and everything checks out, but HEAD routes have names automatically, is this done on purpose?

@efectn
Copy link
Member Author

efectn commented Oct 21, 2023

Hi @Antonov-guap and @trapcodeio. Can you check the PR?

I would love to, but how do I use/test that particular branch?

go get github.com/gofiber/fiber/v2@fix-route-naming should work

Thanks, I have learned something new today 😁.

I just tried it and everything checks out, but HEAD routes have names automatically, is this done on purpose?

Yes i think HEAD routes should have names as well

@efectn efectn requested a review from gaby October 22, 2023 10:34
app_test.go Outdated Show resolved Hide resolved
@ReneWerner87 ReneWerner87 added this to the v2 Next Release milestone Oct 22, 2023
@ReneWerner87 ReneWerner87 merged commit 94acde8 into master Oct 23, 2023
20 checks passed
@efectn efectn deleted the fix-route-naming branch November 7, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: Naming of routes works wrong
5 participants