🚀 Performance improvements #2838

Fenny · 2024-02-08T17:02:54Z

Replace Sprintf with bytebufferpool in ctx.String()
Replace Sprintfwith bytebufferpool in middleware/logger#default
Use optimized utils.ToString and avoid once.Do in log

// OLD middleware/logger Sprintf
Benchmark_Logger/DefaultFormat-24                2205628               545.0 ns/op           208 B/op          8 allocs/op
Benchmark_Logger/DefaultFormat-24                2227387               539.9 ns/op           208 B/op          8 allocs/op
Benchmark_Logger/DefaultFormat-24                2189026               542.1 ns/op           208 B/op          8 allocs/op
Benchmark_Logger/DefaultFormat-24                2223640               548.8 ns/op           208 B/op          8 allocs/op

// NEW middleware/logger bytebufferpool
Benchmark_Logger/DefaultFormat-24                6137152               192.5 ns/op            16 B/op          2 allocs/op
Benchmark_Logger/DefaultFormat-24                6331454               188.7 ns/op            16 B/op          2 allocs/op
Benchmark_Logger/DefaultFormat-24                6390472               188.2 ns/op            16 B/op          2 allocs/op
Benchmark_Logger/DefaultFormat-24                6268698               189.1 ns/op            16 B/op          2 allocs/op

// OLD ctx.String()
Benchmark_Ctx_String-24          3846717               318.0 ns/op           152 B/op          8 allocs/op
Benchmark_Ctx_String-24          3780208               315.9 ns/op           152 B/op          8 allocs/op
Benchmark_Ctx_String-24          3627513               315.1 ns/op           152 B/op          8 allocs/op
Benchmark_Ctx_String-24          3712863               317.4 ns/op           152 B/op          8 allocs/op

// NEW ctx.String()
Benchmark_Ctx_String-24          8131666               149.3 ns/op            96 B/op          5 allocs/op
Benchmark_Ctx_String-24          7626406               148.3 ns/op            96 B/op          5 allocs/op
Benchmark_Ctx_String-24          8194621               149.2 ns/op            96 B/op          5 allocs/op
Benchmark_Ctx_String-24          8297750               156.6 ns/op            96 B/op          5 allocs/op

// OLD log
BenchmarkLogfKeyAndValues/test_logf_with_debug_level_and_key-values-24         	 7323432	       153.8 ns/op	      89 B/op	       1 allocs/op
BenchmarkLogfKeyAndValues/test_logf_with_info_level_and_key-values-24          	 8171703	       144.5 ns/op	      81 B/op	       1 allocs/op
BenchmarkLogfKeyAndValues/test_logf_with_warn_level_and_key-values-24          	 8207860	       142.8 ns/op	      81 B/op	       1 allocs/op
BenchmarkLogfKeyAndValues/test_logf_with_format_and_key-values-24              	 7500332	       159.1 ns/op	     135 B/op	       2 allocs/op
BenchmarkLogfKeyAndValues/test_logf_with_one_key-24                            	10024760	       131.0 ns/op	     155 B/op	       2 allocs/op

// NEW log
BenchmarkLogfKeyAndValues/test_logf_with_debug_level_and_key-values-24         	13797813	        77.42 ns/op	      77 B/op	       0 allocs/op
BenchmarkLogfKeyAndValues/test_logf_with_info_level_and_key-values-24          	15375350	        75.43 ns/op	      73 B/op	       1 allocs/op
BenchmarkLogfKeyAndValues/test_logf_with_warn_level_and_key-values-24          	14926300	        75.28 ns/op	      75 B/op	       1 allocs/op
BenchmarkLogfKeyAndValues/test_logf_with_format_and_key-values-24              	12860275	        90.27 ns/op	     134 B/op	       2 allocs/op
BenchmarkLogfKeyAndValues/test_logf_with_one_key-24                            	15649615	        74.98 ns/op	     100 B/op	       1 allocs/op

- fix expected cookie values in tests

Co-Authored-By: Thomas van Vugt <thomasvvugt@users.noreply.github.com>

Co-Authored-By: Thomas van Vugt <thomasvvugt@users.noreply.github.com> Co-Authored-By: Queru <pascal@queru.net>

Co-Authored-By: RW <renewerner87@googlemail.com>

# Conflicts: # ctx.go # router.go

Co-Authored-By: RW <renewerner87@googlemail.com>

Use optimized `utils.ToString` and avoid `once.Do` **Before** ``` BenchmarkLogfKeyAndValues/test_logf_with_debug_level_and_key-values-24 7323432 153.8 ns/op 89 B/op 1 allocs/op BenchmarkLogfKeyAndValues/test_logf_with_info_level_and_key-values-24 8171703 144.5 ns/op 81 B/op 1 allocs/op BenchmarkLogfKeyAndValues/test_logf_with_warn_level_and_key-values-24 8207860 142.8 ns/op 81 B/op 1 allocs/op BenchmarkLogfKeyAndValues/test_logf_with_format_and_key-values-24 7500332 159.1 ns/op 135 B/op 2 allocs/op BenchmarkLogfKeyAndValues/test_logf_with_one_key-24 10024760 131.0 ns/op 155 B/op 2 allocs/op ``` **After** ``` BenchmarkLogfKeyAndValues/test_logf_with_debug_level_and_key-values-24 13797813 77.42 ns/op 77 B/op 0 allocs/op BenchmarkLogfKeyAndValues/test_logf_with_info_level_and_key-values-24 15375350 75.43 ns/op 73 B/op 1 allocs/op BenchmarkLogfKeyAndValues/test_logf_with_warn_level_and_key-values-24 14926300 75.28 ns/op 75 B/op 1 allocs/op BenchmarkLogfKeyAndValues/test_logf_with_format_and_key-values-24 12860275 90.27 ns/op 134 B/op 2 allocs/op BenchmarkLogfKeyAndValues/test_logf_with_one_key-24 15649615 74.98 ns/op 100 B/op 1 allocs/op ```

# Original fn using Sprintf Benchmark_Ctx_String-24 3846717 318.0 ns/op 152 B/op 8 allocs/op Benchmark_Ctx_String-24 3780208 315.9 ns/op 152 B/op 8 allocs/op Benchmark_Ctx_String-24 3627513 315.1 ns/op 152 B/op 8 allocs/op Benchmark_Ctx_String-24 3712863 317.4 ns/op 152 B/op 8 allocs/op // Modified using bytebufferpool Benchmark_Ctx_String-24 8131666 149.3 ns/op 96 B/op 5 allocs/op Benchmark_Ctx_String-24 7626406 148.3 ns/op 96 B/op 5 allocs/op Benchmark_Ctx_String-24 8194621 149.2 ns/op 96 B/op 5 allocs/op Benchmark_Ctx_String-24 8297750 156.6 ns/op 96 B/op 5 allocs/op

ReneWerner87 · 2024-02-09T09:30:23Z

thx you are awesome

just 2 linter errors and the unneeded comments are pending

fix linter errors
remove old comments

Fenny and others added 30 commits May 24, 2020 15:21

Add new supporter

2473565

Add new test condition

cfd6faa

Add Handler Type

68e4680

Update app.go

08b3a34

Update group.go

78a580c

Add Handler Type

bd1ee67

Update ViewEngine

3777ed6

Update Templates Interface

8c70e9e

Update template examples

a5426fd

Update fasthttp to v1.13.1

a4e6ec7

Default cookie SameSite to Lax

c4567fb

- static file routing fixed for fasthttp 1.13

d33fc42

- fix expected cookie values in tests

Update template examples

8303ce8

Update fasthttp to v1.13.1

85ef29d

Co-Authored-By: Thomas van Vugt <thomasvvugt@users.noreply.github.com>

Cookie SameSite defaults to Lax

7891d33

Co-Authored-By: Thomas van Vugt <thomasvvugt@users.noreply.github.com> Co-Authored-By: Queru <pascal@queru.net>

Fix router bug

98c3528

Co-Authored-By: RW <renewerner87@googlemail.com>

Remove unused code

4883cae

Co-Authored-By: RW <renewerner87@googlemail.com>

Add more static tests

3cc9e23

Co-Authored-By: RW <renewerner87@googlemail.com>

Update app_test.go

faf5245

Co-Authored-By: RW <renewerner87@googlemail.com>

Update Static tests

1d4bef6

Co-Authored-By: RW <renewerner87@googlemail.com>

Update app_test.go

a9018a8

Co-Authored-By: RW <renewerner87@googlemail.com>

Merge remote-tracking branch 'origin/master'

b49a089

# Conflicts: # ctx.go # router.go

Update app_test.go

4609ae5

Co-Authored-By: RW <renewerner87@googlemail.com>

Merge remote-tracking branch 'origin/master'

e7dac31

Fix handler next calls

92fabd9

Co-Authored-By: RW <renewerner87@googlemail.com>

Update router.go

64503b9

Co-Authored-By: RW <renewerner87@googlemail.com>

Update ctx.go

037d88b

Co-Authored-By: RW <renewerner87@googlemail.com>

Merge remote-tracking branch 'origin/master'

c737656

Update app_test.go

4ae98bf

Co-Authored-By: RW <renewerner87@googlemail.com>

Remove nextHandler

8db2ce7

Co-Authored-By: RW <renewerner87@googlemail.com>

ReneWerner87 and others added 5 commits November 20, 2020 11:43

Merge remote-tracking branch 'origin/master'

c77e320

Merge remote-tracking branch 'origin/master'

e8fc61b

Fix WithCtxCaller test

114f86f

Fix lint

6c004cf

Fenny changed the title ~~Small improvements~~ 🚀 Small improvements Feb 8, 2024

Fix lint

fafd1ec

Fenny changed the title ~~🚀 Small improvements~~ 🚀 Small improvement Feb 9, 2024

Fenny added the 🧹 Updates label Feb 9, 2024

Fenny self-assigned this Feb 9, 2024

Fenny added this to the v3 milestone Feb 9, 2024

Fenny changed the title ~~🚀 Small improvement~~ 🚀 Micro improvements Feb 9, 2024

Fenny added 4 commits February 9, 2024 05:01

Fix linting

dbf0510

Use bytebufferpool in default logger

6e3a918

Fix linting

8d51d44

Fenny changed the title ~~🚀 Micro improvements~~ 🚀 Performance improvements Feb 9, 2024

Fenny added v3 🛠 In Progress labels Feb 9, 2024

Fenny and others added 4 commits February 9, 2024 05:25

Lint fix

9b2fd18

Update linter.yml

614a1d5

Update linter.yml

631db7d

Disable caching as recommended by golangci-lint

f7da568

ReneWerner87 approved these changes Feb 9, 2024

View reviewed changes

ReneWerner87 added 2 commits February 9, 2024 12:08

Merge remote-tracking branch 'origin/master'

1496c0e

🩹 fix lint errors

711903f

ReneWerner87 approved these changes Feb 9, 2024

View reviewed changes

ReneWerner87 merged commit 2b03f47 into gofiber:main Feb 9, 2024
14 checks passed

ReneWerner87 removed the 🛠 In Progress label Feb 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🚀 Performance improvements #2838

🚀 Performance improvements #2838

Fenny commented Feb 8, 2024 •

edited

Loading

ReneWerner87 commented Feb 9, 2024 •

edited

Loading

🚀 Performance improvements #2838

🚀 Performance improvements #2838

Conversation

Fenny commented Feb 8, 2024 • edited Loading

ReneWerner87 commented Feb 9, 2024 • edited Loading

Fenny commented Feb 8, 2024 •

edited

Loading

ReneWerner87 commented Feb 9, 2024 •

edited

Loading