-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2: Update benchmark-action to v1.20.3 #3084
Conversation
WalkthroughThe update involves upgrading the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/benchmark.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/benchmark.yml (1)
39-39
: Update tobenchmark-action
version approved.The update from
v1.16.2
tov1.20.3
should resolve the parsing issues and improve the accuracy of the benchmark results.
Description
We are using an older version of the
benchmark-action
in the v2 branch, this is causing the parsing when comparing to v3 to be broken.This can be seen here https://github.com/gofiber/fiber/actions/runs/10040932098 where the values in the right column are not parsed correctly. This was a bug that was fixed a few versions ago after we reported it.