Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Update benchmark-action to v1.20.3 #3084

Merged
merged 1 commit into from
Jul 23, 2024
Merged

v2: Update benchmark-action to v1.20.3 #3084

merged 1 commit into from
Jul 23, 2024

Conversation

gaby
Copy link
Member

@gaby gaby commented Jul 23, 2024

Description

We are using an older version of the benchmark-action in the v2 branch, this is causing the parsing when comparing to v3 to be broken.

This can be seen here https://github.com/gofiber/fiber/actions/runs/10040932098 where the values in the right column are not parsed correctly. This was a bug that was fixed a few versions ago after we reported it.

Copy link
Contributor

coderabbitai bot commented Jul 23, 2024

Walkthrough

The update involves upgrading the github-action-benchmark action within the GitHub Actions workflow from version v1.16.2 to v1.20.3. This change aims to leverage enhancements and potential bug fixes in the newer version, which may improve the benchmarking process. The fundamental structure and logic of the workflow remain unchanged, ensuring continuity while benefiting from the improvements of the updated action.

Changes

File Change Summary
.github/workflows/benchmark.yml Updated github-action-benchmark from v1.16.2 to v1.20.3

Poem

In the meadow, I hop with glee,
Upgrading actions, oh, joy to see!
From v1.16 to v1.20, we cheer,
Better benchmarks, louder and clear!
With each leap, our code takes flight,
Hoppy changes, all feel just right! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gaby gaby requested review from a team, sixcolors, ReneWerner87 and efectn and removed request for a team July 23, 2024 00:51
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1c52689 and 8e6ded5.

Files selected for processing (1)
  • .github/workflows/benchmark.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/benchmark.yml (1)

39-39: Update to benchmark-action version approved.

The update from v1.16.2 to v1.20.3 should resolve the parsing issues and improve the accuracy of the benchmark results.

@ReneWerner87 ReneWerner87 merged commit 87bb93e into v2 Jul 23, 2024
21 checks passed
@efectn efectn deleted the update-bench branch September 1, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants